search

uraway / electron-oauth-github

I do not recommend using this library for OAuth authentication due to security issues. Please use a backend API to keep your access key secret or Auth0 integration.
https://www.npmjs.com/package/electron-oauth-github
16 stars 2 forks source link

what should the callback URL be? #4

Closed choxi closed 7 years ago

choxi commented 7 years ago

When registering a GitHub app, it asks for an oauth callback URL. I wasn't sure what to put there since the oauth request is coming from an Electron app, but when I try to put in a random website domain I get a 404 after the step where I enter my GitHub username and password.

Thanks for the help, hope I'm not missing something obvious.

uraway commented 7 years ago

Hi, @choxi. I upgraded this library. You can put any callback URL like 'example.com'.

Could you try new example?

choxi commented 7 years ago

Yup, I tried it using http://localhost and that works as well. Thank you!

uraway commented 7 years ago

Thanks. I will close this issue.