search

urban-health-labs / CombineFirebase

Combine wrapper on Google's iOS Firebase library.
MIT License
225 stars 44 forks source link

Support Firebase version 7 #13

Closed getogrand closed 3 years ago

getogrand commented 3 years ago

We cannot use Firebase version 7 SDK due to the s.dependency 'FirebaseFirestoreSwift', which is the last non-beta version is '0.4.0'. The 'FirebaseFirestoreSwift 0.4.0' depends on 'FirebaseFirestore ~> 1.6, FirebaseFirestore >= 1.6.1' and it blocks to update Firestore and Firebase SDK version.

This PR sets FirebaseFirestoreSwift to '~> 7.3.0-beta'. It unlocks the updating of FirebaseSDK version, but unfortunately it has beta versioning so it won't be resolved any other version (e.g. 7.3.1-beta, 7.4.0-beta, etc..). So we should change the 'CombineFirebaseFirestore.podspec' on every future 'FirebaseFirestoreSwift' releases.

kshivang commented 3 years ago

Nice PR @getogrand, sorry for responding late was very busy for couple of weeks, will look and test PR by sunday this week. Meanwhile any new thoughts or improvement is very much appreciated.

kshivang commented 3 years ago

This PR redundant as #14, if I am missing any thing please open this again

getogrand commented 3 years ago

@kshivang Both PRs are completely different. The PR #14 handles SPM only. This PR handles CocoaPods. I want to reopen this PR but there is no permission to do that.