search

urban-health-labs / CombineFirebase

Combine wrapper on Google's iOS Firebase library.
MIT License
225 stars 44 forks source link

add SPM Support #8

Closed lorenzofiamingo closed 4 years ago

lorenzofiamingo commented 4 years ago

https://github.com/tomatrow/CombineFirebase

mobiletoly commented 4 years ago

Yes, please, that would be great.

kshivang commented 4 years ago

Follow this: https://github.com/firebase/firebase-ios-sdk/issues/3136 firebase-ios-sdk is the bottleneck currently

tomatrow commented 4 years ago

@lorenzofiamingo Yeah, I couldn't get it working.

quanshousio commented 4 years ago

@kshivang I just implemented support for SPM in #10, would you mind checking it out?

kshivang commented 4 years ago

@quanshousio Sure looking into it

dchakarov commented 4 years ago

I tried adding using SPM and got this error: https://github.com/rever-ai/CombineFirebase has no Package.swift manifest for version 0.2.6 Is there something I'm missing?

Edit: I'm using Xcode Version 12.0 (12A7208)

quanshousio commented 4 years ago

@kshivang Can you tag the latest commit? If someone adds the package using version rule, Xcode will only fetch that repo up until the tagged commit.

@dchakarov For now, you can add the package using branch master.

dchakarov commented 4 years ago

@quanshousio using "master" seemed to work, thank you 💯