urbanadventurer
commented
5 years ago Great work @RootUp but I think it needs a little more work before this plugin is ready to share with others.
Before merging a pull request I always read plugins to check that the quality is very high and ready to share with other users.
I've noticed that in the following pattern, the "@pagekit" string is the relevant twitter handle, so this will only match the main official PageKit website.
{ :name => 'meta', :text=>'<meta property="twitter:site" content="@pagekit">' },
The og:site_name refers to the name of the website, so in this case it again will only match the official homepage.
{ :name => 'meta', :text=>'<meta property="og:site_name" content="Pagekit">' },
The og:url pattern has the same problem.
{ :name => 'URL', :text=>'<meta property="og:url" content="https://pagekit.com/">' },
By the way, PageKit also has this tag and it would make a good addition to the plugin: <meta name="generator" content="Pagekit">
A little trick I use when I am developing a plugin is to collect a group of samples first. I try to make sure the samples represent a range of versions too. It's also really useful to use the -vv modifier so you can see what patterns are matching each website.
Good luck with making new plugins :) ☕️
This adds a plugin to detect pagekit - A modern Open Source CMSIntuitive.