urbanairship / airship-flutter

Flutter integration
Other
17 stars 16 forks source link

[MOBILE-2700] Try to fix crashs #105

Closed Ulrico972 closed 2 years ago

Ulrico972 commented 2 years ago

What do these changes do?

Make notificationId nullable and fix a very weird crash where event.data where nil but goes into the if anyway and then crash on event.data!

Why are these changes necessary?

Try to fix crashs

How did you verify these changes?

I don't reproduce the customer crash so I'm not 100% sure how to fix it properly Also deeplink does not work and I'm digging to find out why it's not. The other weird crash, I just tested it with a push with deeplink

Verification Screenshots:

Anything else a reviewer should know?

I had a very weird crash and also deeplink does not work and I'm digging to find out why it's not. Beside this, I can't reproduce the customer crash so I'm not 100% sure how to fix it properly.