search

urbanairship / android-library

Urban Airship Android SDK
Other
109 stars 123 forks source link

com.urbanairship.android:urbanairship-fcm:16.8.1 notification permission bug #222

Closed wezley98 closed 1 year ago

wezley98 commented 1 year ago

Preliminary Info

What Airship dependencies are you using?

com.urbanairship.android:urbanairship-fcm:16.8.1

Report

What unexpected behavior are you seeing?

Between 16.8.1 and 16.8.0 there seems to be a regression in the Android 13 notification permission behaviour.

16.8.1

  1. Disable notifications at OS level
  2. Every time the app is open it asks to re-enable permissions. <---- bug?

16.8.0

  1. Disable notifications at OS level
  2. Open the app, don't see notification permission.

What is the expected behavior?

The behaviour seen in 16.8.0 is desired.

rlepinski commented 1 year ago

@wezley98 I see where I went wrong. Ill try to have a patch release by tomorrow. 16.8.1 just moved the prompt to after onAirshipReady, so if you are not needing to modify push enabled flags or how it prompts before that callback, 16.8.0 is a fine version to stay on.

rlepinski commented 1 year ago

I have a fix in review, the change is small but going to have our QA team regression test it since I clearly missed a test path

rlepinski commented 1 year ago

Fixed in 16.9