search

urbanairship / capacitor-airship

1 stars 2 forks source link

fix(deps): Remove unused cap dependency #14

Closed jcesarmobile closed 2 months ago

jcesarmobile commented 2 months ago

What do these changes do?

It removes the dependency to cap

Why are these changes necessary?

looks like it was added by mistake and prevents npm install from installing on my computer and it's not being used

How did you verify these changes?

I verified that npm install works fine after removing that dependency and npm run build keeps working

Verification Screenshots:

Anything else a reviewer should know?

rlepinski commented 2 months ago

Thanks for the PR!

Looks like this is just the example package.json, is it causing issues if you install it from NPM? Just trying to figure out how urgent a release is

rlepinski commented 2 months ago

Looks like its just validation from my other issue, going to merge and wait on the release. Thanks again!

jcesarmobile commented 2 months ago

It’s the example app, no no need for a release.