urbanairship / ios-library

Urban Airship iOS SDK
http://urbanairship.com
Apache License 2.0
478 stars 265 forks source link

iOS 11 crash at startup #317

Closed daveburrowz closed 2 years ago

daveburrowz commented 2 years ago

Preliminary Info

What Airship dependencies are you using?

16.5.1

What are the versions of any relevant development tools you are using?

Report

What unexpected behavior are you seeing?

iOS 11 crash on startup

dyld: Library not loaded: /System/Library/Frameworks/Network.framework/Network Referenced from: /private/var/containers/Bundle/Application/F507369A-C571-4BC0-8869-248413C973D7/airshiptest.app/Frameworks/AirshipKit.framework/AirshipKit Reason: image not found

What is the expected behavior?

Does not crash on startup

What are the steps to reproduce the unexpected behavior?

Do you have logging for the issue?

Potential fix

It appears the issue is that the Network library is iOS 12+

I can fix this crash by editing the Airship xxconfig manually and modifying the OTHER_LDFLAGS

Changing: -framework "Network"

To: -weak_framework "Network"

I think this can be done in the Airship podspec by adding:

core.weak_frameworks = "Network"

And removing "Network" from core.frameworks

Looks like this has started happening with the latest version of XCode. As it doesn't look like your podspecs have changed.

Cheers

rlepinski commented 2 years ago

Thanks for the report. I am pretty sure we can just remove Network all together since its an apple framework. Ill have our Paris team check it out

rlepinski commented 2 years ago

We removed Network in our pods and it works as expected for us in 16.6.0. Let us know if it resolves your issue.