search

urbanairship / ios-library

Urban Airship iOS SDK
http://urbanairship.com
Apache License 2.0
478 stars 265 forks source link

Remove use of deprecated API UI_USER_INTERFACE_IDIOM() #319

Closed tahirmt closed 2 years ago

tahirmt commented 2 years ago

What do these changes do?

Remove use of deprecated UI_USER_INTERFACE_IDIOM() function and replace with UIDevice's userInterfaceIdiom property introduced in iOS 3.2

Why are these changes necessary?

Starting Xcode 13.3 when creating an archive the deprecated API throws a compile time error and the only way to fix it is to replace with the new api. Reference

How did you verify these changes?

There was no need to verify as these methods have always been interchangeable.

Verification Screenshots:

Anything else a reviewer should know?

rlepinski commented 2 years ago

Thanks, looks great. Could you sign the CLA so I can merge? Thanks! https://docs.google.com/forms/d/e/1FAIpQLScErfiz-fXSPpVZ9r8Di2Tr2xDFxt5MgzUel0__9vqUgvko7Q/viewform

tahirmt commented 2 years ago

@rlepinski done. Do I need to do anything else?

rlepinski commented 2 years ago

Nope! Ill hopefully get this out today. I am looking at another issue first so it might have to wait til tomorrow

tahirmt commented 2 years ago

@rlepinski any update on when this will be released?

rlepinski commented 2 years ago

@tahirmt just started the 16.7.0 release, should be out in ~1 hour

rlepinski commented 2 years ago

I didnt push a tag to the public repo so the release is now just starting. Sorry for the delay

tahirmt commented 2 years ago

No problem. Thanks for the update