urbanairship / ios-library

Urban Airship iOS SDK
http://urbanairship.com
Apache License 2.0
478 stars 265 forks source link

In-App Automation Modal doesn't get dismissed on button press #355

Closed mmdumi closed 1 year ago

mmdumi commented 1 year ago

Preliminary Info

What Airship dependencies are you using?

Latest version 16.11.2

What are the versions of any relevant development tools you are using?

xcode 14.2

Report

What unexpected behavior are you seeing?

I've got an in app automation running that shows a modal template correctly. The template offers a button that triggers a deeplink into the app. Pressing the button calls the following delegate implementation:

func receivedDeepLink(_ url: URL, completionHandler: @escaping () -> Void) {
    onReceivedURL?(url)
    completionHandler()
  }

On android the same automation calls the delegate but then dismisses the modal. On iOS the modal doesn't get automatically dismissed.

What is the expected behavior?

The modal should get dismissed on template button press.

What are the steps to reproduce the unexpected behavior?

Create an in app automation with a simple template + button that triggers a deeplink.

rlepinski commented 1 year ago

@mmdumi Which path did you take when creating the message? Classic, Template, or Interactive Editor?

Screenshot 2023-03-09 at 7 12 17 AM
mmdumi commented 1 year ago

It was template and I did choose a default template with button

rlepinski commented 1 year ago

Thanks, trying to reproduce with your exact setup. Template & Interactive Editor produce HTML based IAA and dismiss differently vs the classic ones.

mmdumi commented 1 year ago

Thank you. Please try with html ones.

rlepinski commented 1 year ago

When you created your content, did you check this box:

Screenshot 2023-03-09 at 16 53 13
mmdumi commented 1 year ago

That was it. Thank you @rlepinski You can close the issue

rlepinski commented 1 year ago

🎉