urbanairship / ios-library

Urban Airship iOS SDK

http://urbanairship.com

Apache License 2.0

478 stars 265 forks source link

Fix LICENSE file #389

Closed stherold closed 7 months ago

stherold commented 9 months ago

Report

What unexpected behavior are you seeing?

We now have to verify our licenses against a central file and we use License Plist to find the licenses for all of our dependencies. For Airship it cannot detect the proper license type though.

I recognized that your LICENSE file differs quite a bit from e.g. the one Google Maps is using, which is recognized by the tool.

What is the expected behavior?

Can you fix your license file so it matches an official version of the Apache 2.0 license?

Here you can find the official license text: https://www.apache.org/licenses/LICENSE-2.0.txt

rlepinski commented 9 months ago

We can probably update it but its something that I will have to run by our legal team

stherold commented 8 months ago

That would be nice :)

rlepinski commented 8 months ago

@stherold I did submit this to legal when you first posted it, ill ping them again on it

Blackjacx commented 8 months ago

Thanks for being so fast 🙏 I'm looking forward. We can then remove manual specification of the license for Airship and just let License PLIST figure it out 👍

rlepinski commented 7 months ago

@Blackjacx @stherold I got approval to update the license. Sorry for the delay. Is it possible for you to update to 18.x?

rlepinski commented 7 months ago

Fixed in 18.1.0. I don't think I need to back port this since I believe its just for the repo using the the Github API without a branch/ref - https://github.com/mono0926/LicensePlist/blob/main/Sources/LicensePlistCore/GitHubClient/RepoRequests.swift#L15

But I only browsed the code for a few minutes. Let me know if you have any issues.

Blackjacx commented 7 months ago

Hey there 👋 thank you very much! Yes 18.x is totallly fine 👍