search

urbanairship / python-library

A Python library for using the Airship APIs for push notifications, reporting and other message types
https://docs.airship.com/api/libraries/python/
Other
82 stars 67 forks source link

Dictionary should be allowed as a valid iOS alert. #14

Closed keleshev closed 9 years ago

keleshev commented 10 years ago

There is a typo on line 56:

https://github.com/urbanairship/python-library/blob/master/urbanairship/push/payload.py#L56

It should say:

if not (isinstance(alert, basestring) or isinstance(alert, dict)):

Instead of:

if not isinstance(alert, basestring) or isinstance(alert, dict):
pdxmele commented 9 years ago

Sorry, we didn't have any dedicated staff to maintain the library for some time. However, we're picking it up again now, so look for improvements, questions, and merges soon.

Please sign the Contribution Agreement if you haven't done so already (required before we can merge in PRs): http://urbanairship.com/legal/contribution-agreement

pdxmele commented 9 years ago

We haven't heard back from you about a Contribution Agreement, so we've fixed it our internal version. Keep an eye out for a release soon!