search

urbanairship / python-library

A Python library for using the Airship APIs for push notifications, reporting and other message types
https://docs.airship.com/api/libraries/python/
Other
82 stars 65 forks source link

Actually implement the message extra argument #17

Closed vially closed 9 years ago

vially commented 10 years ago

The extra argument of the message function is documented but it is not actually implemented.

rudyryk commented 10 years ago

Hi @vially! I've merged your commit to https://github.com/05bit/python-urbanairship3

vially commented 10 years ago

@rudyryk Awesome. Thanks.

Are there any plans for your changes to be merged back into this project so there can be only one urban airship library with support for both python 2 and 3?

rudyryk commented 10 years ago

@vially Sure, it would be great, I'm not planning turn it into separate project! But my pull request is pending since last year :)

rudyryk commented 10 years ago

@vially I've also merged some other pull requests that seemed reasonable and backward compatible. All tests are passing, so I think merging back would not be a problem at all.

vially commented 10 years ago

Great. If only someone with commit access would take a look at them and merge them

/cc @robotadam @mhooge @Brett-S

pdxmele commented 9 years ago

Sorry folks, we didn't have any dedicated staff to maintain the library for some time. However, we're picking it up again now, so look for improvements, questions, and merges soon.

Please sign the Contribution Agreement if you haven't done so already (required before we can merge in PRs): http://urbanairship.com/legal/contribution-agreement

vially commented 9 years ago

@pdxmele I just signed the Contribution Agreement

pdxmele commented 9 years ago

Great, thanks!

pdxmele commented 9 years ago

Works for me locally and tests still passing, you have my :+1: (and I got another verbal +1 from @robotadam as well). Merging in.