Package Types with library - Githubissues

urbanairship / python-library

A Python library for using the Airship APIs for push notifications, reporting and other message types

https://docs.airship.com/api/libraries/python/

Other

82 stars 65 forks source link

Package Types with library #57

Open rushildev opened 1 year ago

rushildev commented 1 year ago

All bugs, feature requests, implementation concerns or general queries should be sent to our support team.

You are welcome to submit an issue here for bugs, but please also reach out to our support team as well.

Before completing the form below, please check the following:

[ ] You are using the most recent version of the library.
[ ] You are using a supported version of Python for that library version.
[ ] This issue is reproducible.

Expected Behavior

The library should be packaged with type annotations.

Current Behavior

The library does not included type annotations

Possible Solution

Support PEP 561 -- include types in published package

Steps to Reproduce

Install urbanairship in a python project
Import any class from the urbanairship package
Run a type linter like mypy
Observe that linter will report urbanairship is missing type annotations.

Detailed Description

It appears as if the library source code is typed. Why not also package the types along for consumers that leverage type annotations.

Possible Fix

pdxmele commented 1 year ago

Thanks, we've made a ticket for this on our side and will get to it when we have the chance