urbanairship / react-native-airship

Airship React Native module
Other
88 stars 62 forks source link

IOS: Module 'AirshipKit' not found #101

Closed erez-guesty closed 6 years ago

erez-guesty commented 6 years ago

Xcode 9.2

I follow Carthage setup method: https://github.com/urbanairship/ios-library

$ brew update $ brew install carthage

Cartfile

github "urbanairship/ios-library"

then ran command

$ carthage update

then follow Carhage instructions:

If you're building for iOS, tvOS, or watchOS

  1. On your application targets’ General settings tab, in the “Linked Frameworks and Libraries” section, drag and drop each framework you want to use from the Carthage/Build folder on disk.

  2. On your application targets’ Build Phases settings tab, click the + icon and choose New Run Script Phase. Create a Run Script in which you specify your shell (ex: /bin/sh), add the following contents to the script area below the shell:

/usr/local/bin/carthage copy-frameworks

  1. Add the paths to the frameworks you want to use under “Input Files”, e.g.:

    $(SRCROOT)/Carthage/Build/iOS/Result.framework $(SRCROOT)/Carthage/Build/iOS/ReactiveSwift.framework $(SRCROOT)/Carthage/Build/iOS/ReactiveCocoa.framework

  2. Add the paths to the copied frameworks to the “Output Files”, e.g.:

    $(BUILT_PRODUCTS_DIR)/$(FRAMEWORKS_FOLDER_PATH)/Result.framework $(BUILT_PRODUCTS_DIR)/$(FRAMEWORKS_FOLDER_PATH)/ReactiveSwift.framework $(BUILT_PRODUCTS_DIR)/$(FRAMEWORKS_FOLDER_PATH)/ReactiveCocoa.framework

image

image

image

any ideas ??

rlepinski commented 6 years ago

@erez-guesty what version of carthage are you using? My sample works but I am on .24. Coworkes sample does not and he is running the latest Carthage. Not sure what changed in Carthage or if its just my particular setup that is making it work, but we are looking into it.

MaxInMoon commented 6 years ago

Same here: "framework not found AirshipKit" when building (I used cocoa pods)

BrianBatchelder commented 6 years ago

@erez-guesty: in Xcode, please try adding the following build setting to the UARTCModule sub-project's Build Settings using Editor -> Add Build Setting -> Add User-Defined Setting:

Key = AIRSHIP_SEARCH_PATH
Value = $(SRCROOT)/../../../ios/Carthage/Build/iOS

You may need to change the path to match wherever your Carthage build is.

BrianBatchelder commented 6 years ago

@MaxInMoon : since this issue is a Carthage issue, not a CocoaPods issue, could you please check your steps and file a new issue if the problem persists?

rlepinski commented 6 years ago

@MaxInMoon @erez-guesty We should have a patch tomorrow with better library search paths that will hopefully resolve the issues. Not sure why/how others are able to make it work. Our Sample directory name was embedded in the search paths.

MaxInMoon commented 6 years ago

@rlepinski @BrianBatchelder thanks for your time. To bring feedback to my prvious message, my "CocoaPods" issue was that I was open Xcode project with myapp.xcodeproj instead of myapp.xcworkspace.

BrianBatchelder commented 6 years ago

@erez-guesty : This issue has been fixed in Release 1.6.1.