search

urbanairship / react-native-airship

Airship React Native module
Other
88 stars 62 forks source link

[Android]: 'channelEditTags' overrides nothing #528

Closed orel91 closed 1 year ago

orel91 commented 1 year ago

Preliminary Info

What Airship dependencies are you using?

@ua/react-native-airship: 16.1.0

Report

What unexpected behavior are you seeing?

I get the following error when trying to compile the app (new architecture is NOT enabled): e: /PROJECT_PATH/node_modules/@ua/react-native-airship/android/src/main/java/com/urbanairship/reactnative/AirshipModule.kt: (164, 5): 'channelEditTags' overrides nothing

What is the expected behavior?

The app should compile

What are the steps to reproduce the unexpected behavior?

The relevant code is located here in your repo: https://github.com/urbanairship/react-native-airship/blob/cd6f0d1bbb526aeaf6b256863d8cb11eec245440/android/src/main/java/com/urbanairship/reactnative/AirshipModule.kt#L164 And you can see that there is no method called channelEditTags in the AirshipSpec class: https://github.com/urbanairship/react-native-airship/blob/main/android/src/oldarch/java/com/urbanairship/reactnative/AirshipSpec.kt

rlepinski commented 1 year ago

Will get it fixed today, thanks for the report.

rlepinski commented 1 year ago

Should be fixed in 16.1.1