search

urbanairship / react-native-airship

Airship React Native module
Other
87 stars 62 forks source link

Incorrect type definition on `listIconUrl` #553

Closed Peter-ChengTszTung closed 7 months ago

Peter-ChengTszTung commented 7 months ago

Expecting listIconUrl?: string; instead of listIconUrl: string;

https://github.com/urbanairship/react-native-airship/blob/218bfe9a9e7b6935b2589e577262daf641874442/src/types.ts#L562-L567

crow commented 7 months ago

Good catch. Thanks!

crow commented 7 months ago

Have the change here - will include in the next release after coming through the rest of the typescript definitions and testing. Thanks again.