Closed bvicenzo closed 6 years ago
@bvicenzo This PR looks great. I think its totally reasonable for the log level to default to info instead of debug. Could you make that change?
@rlepinski Thanks! Sure. The change is here: https://github.com/urbanairship/ruby-library/pull/106/commits/ab6f5e08c52efb64a76a6f28a8e719de6d3b2436
Guys, please, let me know if is missing something to go ahead with this PR.
@rlepinski Will this PR be merged in the next version?
We are looking at this now.
Looking for this issue https://github.com/urbanairship/ruby-library/issues/96 i've built a way to make the gem configurable.
Starting from log parameters. But we can use this structure do make anything we could do as configurable options.
The way to use is very simple. In a Rails app, for example, we can create a file in
config/initializers/urbanairship.rb
with the following content.To do this, I'm based on these articles: https://robots.thoughtbot.com/mygem-configure-block http://lizabinante.com/blog/creating-a-configurable-ruby-gem/