Allow to use a custom logger

urbanairship / ruby-library

A Ruby wrapper for the Urban Airship API.

Other

200 stars 117 forks source link

Allow to use a custom logger #116

Closed danielvidal closed 5 years ago

danielvidal commented 5 years ago

What does this do and why?

The current implementation forces the log to be written in a disk file. As I need to log in a stream via STDOUT, I created a configuration that allows the UA lib to set a custom logger of any kind (e.g. STDOUT logger, ActiveSupport's tagged logger).

Testing

[x] I wrote tests covering these changes

Urban Airship Contribution Agreement

https://docs.urbanairship.com/contribution-agreement/

[x] I've filled out and signed UA's contribution agreement form.

aschuman0 commented 5 years ago

Thank you for the pull request @danielvidal. We will take a look shortly and get back to you with any questions.

bvicenzo commented 5 years ago

@danielvidal Nice work, man! 👏 You could also, add how to configure a custom log Readme 😉

sarahdactyl71 commented 5 years ago

All tests pass