urbanairship / ruby-library

A Ruby wrapper for the Urban Airship API.
Other
200 stars 117 forks source link

Sending a request with Auth Token instead of Basic Auth. #122

Closed ricksuggs closed 3 years ago

ricksuggs commented 3 years ago

If you want your PR addressed quickly, please also reach out to our support team so we can understand when you need it reviewed and how it is impacting your use of our services. We also generally will not release new versions of our library without new feature support, a bug fix, or a clear reason from a customer why an update is required to minimize how often other customers need to update.

What does this do and why?

This adds parameters to the UA::Client constructor & UA::Client.send_request method to specify auth token parameters. The custom events endpoint requires Bearer Authentication, while every other endpoint requires Basic.

https://docs.airship.com/api/ua/index.html#operation/api/custom-events/post

Additional notes for reviewers

Testing

Airship Contribution Agreement

Link here

Screenshots

aschuman0 commented 3 years ago

Hi @ricksuggs. Thank you for the pull request and signing the contribution form! We will review this in the next few days and get back to you here if we have any questions. Please feel free to comment if there is any more we can do for you in the meantime.