Closed ricksuggs closed 3 years ago
Hi @ricksuggs. Thank you for the pull request and signing the contribution form! We will review this in the next few days and get back to you here if we have any questions. Please feel free to comment if there is any more we can do for you in the meantime.
If you want your PR addressed quickly, please also reach out to our support team so we can understand when you need it reviewed and how it is impacting your use of our services. We also generally will not release new versions of our library without new feature support, a bug fix, or a clear reason from a customer why an update is required to minimize how often other customers need to update.
What does this do and why?
This adds parameters to the
UA::Client
constructor &UA::Client.send_request
method to specify auth token parameters. The custom events endpoint requires Bearer Authentication, while every other endpoint requires Basic.https://docs.airship.com/api/ua/index.html#operation/api/custom-events/post
Additional notes for reviewers
Testing
[x] If these changes added new functionality, I tested them against the live API with real auth
[x] I wrote tests covering these changes
I've tested for Ruby versions:
[x] 2.2.5 - I had to remove the
guard-rspec
dependency in order to install the bundle under ruby 2.2.5[x] 2.3.1
[x] 2.5.7
Airship Contribution Agreement
Link here
Screenshots