Fix bad `associate` endpoint, add test

lloydwatkin commented 3 years ago

If you want your PR addressed quickly, please also reach out to our support team so we can understand when you need it reviewed and how it is impacting your use of our services. We also generally will not release new versions of our library without new feature support, a bug fix, or a clear reason from a customer why an update is required to minimize how often other customers need to update.

What does this do and why?

Fixes the URL used by the associate endpoint. It currently adds a double slash which results in an error. Added missing test coverage for this
Cast named_user_id to a string in associate endpoint so users can pass in internal IDs

Additional notes for reviewers

Ticker 77316 on your internal systems

Testing

[x] If these changes added new functionality, I tested them against the live API with real auth
[x] I wrote tests covering these changes
I've tested for Ruby versions:
[x] 2.2.5
[x] 2.3.1
[x] Ruby 2.7.2. The above versions are very old. See test output here https://travis-ci.com/github/OLIOEX/ruby-library/builds/231341049

Airship Contribution Agreement

Link here

[x] I've filled out and signed Airship's contribution agreement form.

Screenshots

If applicable

pdxmele commented 3 years ago

Thanks! Taking a look at this now.

lloydwatkin commented 3 years ago

Thanks both. If you can pass on some feedback on my branch from #129 I'd really appreciate it too. I'd rather not diverge from the official repo if I have to. There's also other features I need to implement (eg delete named user) so it would be great to contribute them back and get them released in a timely manner.

pdxmele commented 3 years ago

Yes I would like to review and merge in your PRs, then do some changes on my end, then do a release. I was already planning to fix the other named user endpoints... are there any other things you were planning to do outside of that and your open PRs?

urbanairship / ruby-library