search

urbanairship / ruby-library

A Ruby wrapper for the Urban Airship API.
Other
200 stars 118 forks source link

tag_device and untag_device #33

Closed ghost closed 11 years ago

ghost commented 11 years ago

Adding device to the tag or removing the device from the tag seems to be not working correctly and has different requests http://docs.urbanairship.com/reference/api/tags.html

schoblaska commented 11 years ago

Good catch. Either this was never working, or they've changed the tag API since it was first written.

If @provider == :android, we should probably pass these as "apids" instead of "device_tokens" as well. Do you want to add that? Otherwise I can merge this and add it myself.

ghost commented 11 years ago

Right, I forgot about android. I think, now it's fine. If something is wrong or could be done better, please just improve.

schoblaska commented 11 years ago

Great, thanks! I'll merge this in and do a version bump.