Request to Merge for Custom Payloads

[eddieroger]

Hey guys,

I think your library is great - by far better than the "recommended" library on UA's site, but the one thing I noticed it didn't support that I wanted was the ability to pass down custom payloads. So, I made a super small modification to your awesome library to allow for a custom payload to be enclosed. It doesn't allow for arbitrary data, just a :custom symbol and whatever data the user wants to include (non-sensitive, of course).

Thought it might be useful. Maybe not. Either way, thanks for the library. -Eddie

My commit message: Modified VALID_PUSH_PARAMS to accept :custom symbol, allowing a custom payload to accompany the notification.

[schoblaska]

Thanks for the pull request! Out of curiosity, what's the use case for this? The :aps parameter already accepts a hash with arbitrary key / values, which will get sent to the device as part of the push notification package.

[eddieroger]

Well, this is embarrassing. When I read through the APNS documentation on push, I read it as custom payloads should be siblings of the APN object, not children. It worked for me when I modified, and my app received the packet as expected, but I will go back and try it with my payload being a child and make sure it still works. If so, feel free to disregard my note!

On Thu, Oct 27, 2011 at 11:35 AM, Joey Schoblaska < reply@reply.github.com>wrote:

Thanks for the pull request! Out of curiosity, what's the use case for this? The :aps parameter already accepts a hash with arbitrary key / values, which will get sent to the device as part of the push notification package.

Reply to this email directly or view it on GitHub: https://github.com/groupon/urbanairship/pull/6#issuecomment-2545032

• Eddie Eddie Roger | eddieroger@gmail.com | eddieroger.com

[schoblaska]

Confirmed that passing custom values in the :aps parameter satisfy this use case. Closing the pull request for now.