search

urbanairship / ruby-library

A Ruby wrapper for the Urban Airship API.
Other
200 stars 117 forks source link

Wrap blank payload with Array.wrap #83

Closed seth-macpherson closed 8 years ago

seth-macpherson commented 9 years ago

Fixes error caused by blank payload being returned from send_push


NoMethodError:
  undefined method `each' for "":String
  # /work/ruby-2.2.2@nasa/gems/urbanairship-3.0.2/lib/urbanairship/push/push.rb:183:in 'format'
  # /work/ruby-2.2.2@nasa/gems/urbanairship-3.0.2/lib/urbanairship/push/push.rb:49:in 'block in send_push'
  # /work/ruby-2.2.2@nasa/gems/urbanairship-3.0.2/lib/urbanairship/push/push.rb:49:in 'send_push'
bswinnerton commented 9 years ago

:+1:

jkvoorhis commented 9 years ago

@seth-macpherson thank you for your PR, we are reviewing it and determining how this fix fits in with our upcoming releases. In the meantime would you please sign and submit a contributor's agreement?

seth-macpherson commented 9 years ago

@jkvoorhis done

seth-macpherson commented 9 years ago

@bswinnerton Did you run into this as well?

jkvoorhis commented 8 years ago

@seth-macpherson we decided to resolve this issue in a different way, and have released it with Version 3.1.0 along with support for many additional API endpoints. I am going to close out this PR, thank you for your contribution and patience!