Urban airship is indirectly depending on insecure version of rest-client through unirest dependency

urbanairship / ruby-library

A Ruby wrapper for the Urban Airship API.

Other

200 stars 117 forks source link

Urban airship is indirectly depending on insecure version of rest-client through unirest dependency #86

Closed paneq closed 7 years ago

paneq commented 9 years ago

https://github.com/Mashape/unirest-ruby/issues/24

It would be nice to help Mashape to upgrade to newest version of rest-client

justinsoong commented 8 years ago

This is kinda of an issue huh

noam87 commented 8 years ago

is unirest being actively maintained? I see two unmerged PRs about this issue... it's also causing dependency issues.

philtr commented 8 years ago

Hey, didn't even see this. I just submitted #94 to remove the Unirest dependency.

schaternik commented 8 years ago

hey @philtr

what's the problem that your PR is not in master now?

philtr commented 8 years ago

@nastia-shaternik if I remember correctly it didn't handle error responses quite as gracefully as Unirest. I was trying to use Net::HTTP instead. It would probably be a lot easier to move to RestClient instead if you want to take a stab at that. IMO API wrappers should use Net::HTTP, but I didn't have time to debug.

pdxmele commented 7 years ago

This is now fixed, thanks for the report!