search

urbanairship / ruby-library

A Ruby wrapper for the Urban Airship API.
Other
200 stars 117 forks source link

Remove Unirest dependency #94

Closed philtr closed 8 years ago

philtr commented 8 years ago

I was having a dependency version conflict with RestClient, which was being used by Unirest. I swapped it out for Net::HTTP for use in our application.

I wasn't sure if this is a desired change, but I figured I'd submit a PR and see. Then I found #86 and it seems like this is an issue affecting several others as well.

paneq commented 8 years ago

Looks good. How should it handle exceptions though?

philtr commented 8 years ago

I was considering adding a separate class to handle the sending the HTTP request and parsing the response. It could work as a drop-in replacement for the Unirest call.

How does Unirest handle exceptions?

philtr commented 8 years ago

So we keep finding little holes where this is just not working. I am closing this pull request for now. We are going to just point to a forked version of Unirest until it is updated.