search

urbanarchive / qpl-name-explorer

White label site for QPL Name Explorer
2 stars 2 forks source link

Add an active pin icon #62

Open isaacbw opened 1 year ago

isaacbw commented 1 year ago

Add a new pin icon for when a user selects a location. Right now it's hard to tell what's currently active on the map. Google maps does this.

https://www.figma.com/file/5c2dvt1wE0Zq2vdTyveQBW/QPL-White-Label?node-id=403%3A677

Image

isaacbw commented 1 year ago

When you click on an icon on the map the pin doesn't display. Only shows when you select an asset from the content bar.

allthesignals commented 1 year ago

@isaacbw are you sure about that? I can't reproduce this.

isaacbw commented 1 year ago

Here's a screen recording of it. (I tried it on chrome and safari and had the same issue)

https://user-images.githubusercontent.com/108014276/193120354-6e9ebb69-8f39-4fdb-9410-9e2545747c36.mov

allthesignals commented 1 year ago

Yeah, that looks right to me. A location can have multiple images/details. So the pin only appears when you're looking at a detail of a single image.

allthesignals commented 1 year ago

@isaacbw let's review this tomorrow. This is how it has behaved for some time now. Let's figure out how the thing show flow.

allthesignals commented 1 year ago

@isaacbw the issue is that some locations have multiple assets, like this: https://nameexplorer.urbanarchive.me/monuments?key=fld03C27tmVnEg1rP&value=40.736600833162434,%20-73.82008734696673

allthesignals commented 1 year ago

@isaacbw take another look. if it's not behaving the way you expected let's go over it tomorrow.