search

urbanarchive / qpl-name-explorer

White label site for QPL Name Explorer
2 stars 2 forks source link

New icon update for "Other" type entries #74

Open isaacbw opened 1 year ago

isaacbw commented 1 year ago

Currently the QPL logo "Q" is the icon. The icon on slack-- https://urbanarchive.slack.com/archives/C0305M2E8BW/p1667940253156439?thread_ts=1667939429.940649&cid=C0305M2E8BW

isaacbw commented 1 year ago

Need to review this. The icon for the "Other - Describe in Additional notes" monument field type is not displaying correctly. There's only one asset live with this type so that's probably why we haven't caught it.

Screenshot of the "other" assets. Image

Here's the single live "other" asset:

Here's the "other" icon that Ben made: Image

allthesignals commented 1 year ago

https://nameexplorer.urbanarchive.me/locations/rabbi-dr-i-usher-kirshblum-memorial-recd43RUkno2n9WeX example

allthesignals commented 1 year ago

@benpsmyth @isaacbw this should be good for review (thanks @dcnfgr)

isaacbw commented 1 year ago

need to add this to filter type on the dropdown menu!

benpsmyth commented 1 year ago

@allthesignals can you add this to the dropdown menu too?

allthesignals commented 1 year ago

Yes, should be done... ready for review