search

urbandroid-team / dont-kill-my-app

Android vendors, don't kill my app!
Creative Commons Attribution 4.0 International
1.28k stars 2.98k forks source link

Feedback for Samsung page #298

Open Korico opened 3 years ago

Patryz commented 3 years ago

Just FYI, on my device galaxy M51, just updated to 11, it kind works opposite from what's written on the page: if I disable all battery optimization and all battery saving features from the device care section, apps will still get killed (segmentation warnings from accubattery and inability to change tracks from smartband due to app getting killed).

However, if I enable optimization for all apps and add the specific apps I need to the "never sleep" section in the device battery care, everything works fine, and battery also lasts much longer.

petrnalevka commented 3 years ago

Hello @Patryz big thanks for the udpate. We are still investigating this and at the moment it is not clear what is Samsung intended behavior and what may be bugs in Samsung Android 11 implementation.. We are keen on any feedback on this.. please also see https://github.com/urbandroid-team/dont-kill-my-app/issues/307#issuecomment-827649020

tprochazka commented 3 years ago

I really don't understand why Samsung is #1. Samsung is exactly the oposite. Yes. It kill the apps, but it notify user that it happen and user had possibility to react and whitelist every app.

JonRC commented 3 years ago

I really don't understand why Samsung is #1. Samsung is exactly the oposite. Yes. It kill the apps, but it notify user that it happen and user had possibility to react and whitelist every app.

How can I do it?

petrnalevka commented 3 years ago

Hello @tprochazka, many thanks for your feedback. The score for Samsung is based on several observations:

  1. After the Pie update the number of background processing issues reported skyrocketed for Samsung. Before most problems were reported from 1+, Huawei, Xiaomi etc.. But now it is Samsung, I know they have the biggest market share, but we simply do not have the data to abstract from that. And the fact is that most issues nowadays simply come from Samsung.
  2. We have reports that Samsung is killing foreground services by default on their Android 10 update. See https://issuetracker.google.com/issues/179644471 and https://github.com/urbandroid-team/dont-kill-my-app/issues/307.. We are now investigating the latest update that this has been fixed and if it holds we will consider a lower score for Samsung, but for now we keep it to keep cautious about Samsung.
  3. We have many reports that even when you whitelist an app Samsung can put it to the restricted lists again later on based on various criteria. One of them could be crashes in the app.. We have seen this massively in the recent WebView issue introduced by Google. Suddenly whitelisted apps become restricted again. So even the WebView issue was fixed by Google promptly, the effect of it is long lasting thanks to Samsung policies.
  4. At the moment we have no evidence Samsung notifies users of app killing (or moving the apps to their restricted lists). Could you please post some evidence? Ideally a screenshot? Is this a notification? Anyway whatever Samsung does it is not sufficient. So many users simply don't have the slightest clue of what is Samsung doing and blames the developers of misbehavior. 5.Putting apps to restricted mode based days of no usage - we have reports that Samsung can put apps on the list of sleeping apps after 3 days of not being used - is IMHO hideous.. it is a caricature of Google intended with Adaptive battery 6.The market share may also be seen as the reason to give Samsung 5 crap score because it is simply so important what policies Samsung implements. At the moment IMHO Samsung has one of the worst app killing implementation on the market. It may not be the #1 top worst, but Samung's market share makes it simply the one with the most negative impact in the ecosystem.

Hope that explains it a little big more. Any evidence about point 4. is very much appreciated..

petrnalevka commented 3 years ago

BTW @tprochazka to demonstrate the issue from a more practical side..

We are maintaining a smart alarm clock app.. We are getting some 10-20 complains every single day very similar to the one I just resolved, here: "I've used this app for nearly 10 years. It no longer works after the last few updates. The alarm doesn't go off anymore, which made me late to work a few times. I've stopped using it and switched to Alexa since I can't trust it....Very sad, because I always loved the app and trusted it completely. No more."

Of course most people do not write, they just uninstall straight away..

We reply with the guide at https://dontkillmyapp.com/samsung and in 99% cases users resolve the issue and everything is working at least for some time before Samsung decides it's time to put the app back to the sleeping apps list of disabled apps list or whatever..

But those Samsung users have ABSOLUTELY NO IDEA why their favorite alarm clock app just stopped working out of the blue. They are late for work and blame the dev of course.

For ~20 Samsung issues we get some ~4 issues from 1+ devices and ~2 from Huawei and Xiaomi each every day...

tprochazka commented 3 years ago

I understand. I have a TV Guide app (with notification to your favorite programs) and luckily almost zero complaints from Samsung, just Huawei and Xiaomi. But it is obvious why. Samsung put the app to sleep (or deep sleep) when you did not use them (not open from launcher) An alarm clock is a good example of an app that you set once and then do not open for a long time.

Samsung shows a notification when he put apps to sleep, so the user has the ability to easily react to this and prevent it. This is why I think that Samsung is not so bad.

For example Huawei, according to your description is the only way to uninstall some app via ADB in developer mode. Which is a completely different level of complexity for normal users.

dedsecorg commented 2 years ago

Correct me if im wrong tho, but it seems like there has been some improvements here lately? It seems that on a S10 Plus, that it actually works putting the apps to: Unrestricted (in app settings on phone) And in special permissions going in from the hamburger-menu.

petrnalevka commented 2 years ago

@godzillamesel reports from our users are still indecisive. It seems Smasung is testing different approaches and every device is behaving differently. On some devices putting to unrestricted lists will help, on thers users have no control and Chimera policy manager just stops any foreground service running. Recently I saw reports from S22 and a52 users that they need to use "don't optimize this app" on the standard battery settings to prevent Samsung's non-standard app killing. This is a bad news as this setting is regulated by the Play Store and promoiting users to set it can lead to removing the app from the Play Store..

petrnalevka commented 2 years ago

BTW look at this thread https://github.com/urbandroid-team/dont-kill-my-app/issues/307#issuecomment-1094125524