urbangrammarai / gee_pipeline

Pipeline for retrieving imagery from Google Earth Engine
MIT License
1 stars 0 forks source link

Add CI testing of unittests and linting #16

Closed andrewphilipsmith closed 2 years ago

andrewphilipsmith commented 2 years ago

Initially, add whitespace and pretty-print formatters.

andrewphilipsmith commented 2 years ago

@crangelsmith - I think that this is now ready to merge.

This reproduces in GitHub Actions some of the tests that are run in Travis-CI in monitoring-ecosystem-resilience.

Additionally, this PR adds linting rules via pre-commit (black, isort, autopep8, various whitespace formatters). These rules are repeated on the CI. As a result, this PR touches a lot of files - though most of these changes are minor. (With the benefit of hindsight I think that this should have been two separate PRs).

If/when merged, this PR would close #1.

andrewphilipsmith commented 2 years ago

I see the pre-commit hooks checks are failing after updating main with PR #14 , anything I should do on that front?

Not for now thanks - I'm working on this and will let you know if there is anything.

andrewphilipsmith commented 2 years ago

I have disabled a second test on CI, due to issue #20. In this case, I suspect (though haven't confirmed) that the problem is with the test code, not the CI or the production code.

In order to complete this PR, I've opted to disable the test on CI, rather than delay implementing the rest of the CI/liniting checks.