search

urbanopt / geojson-modelica-translator

GeoJSON to Modelica Translator that is focused on district energy system design and analysis.
https://www.nrel.gov/buildings/urbanopt.html
Other
18 stars 11 forks source link

Closed-loop changes to existing test_single_ghe test #596

Closed JingWang-CUB closed 10 months ago

JingWang-CUB commented 10 months ago

Any background context you want to provide?

URBANopt GHP project

What does this PR accomplish?

Change existing single GHE test to be closed-loop

How should this be manually tested?

Poetry run the test_single_ghe.py and then simulate the model in Dymola/OM

What are the relevant tickets?

None

Screenshots (if appropriate)

vtnate commented 10 months ago

@JingWang-CUB It's easier for others to see the changes you've made for this task if you start a new branch (maybe branching off a previous branch, if applicable). Can you experiment with that next time you work on the GMT? 🙇

JingWang-CUB commented 10 months ago

@JingWang-CUB It's easier for others to see the changes you've made for this task if you start a new branch (maybe branching off a previous branch, if applicable). Can you experiment with that next time you work on the GMT? 🙇

Hi Nate, thanks for pointing this out. I've noticed this before as well, every time I branch off the latest dev branch, some older commits appear in my PR which was not my intention, but the files changed are correct. Could you please let me know which branch I should base my branch on or what I've possibly done wrong?