Closed-loop changes to existing test_single_ghe test

urbanopt / geojson-modelica-translator

GeoJSON to Modelica Translator that is focused on district energy system design and analysis.

https://www.nrel.gov/buildings/urbanopt.html

Other

18 stars 11 forks source link

Closed-loop changes to existing test_single_ghe test #597

Closed JingWang-CUB closed 9 months ago

JingWang-CUB commented 10 months ago

Any background context you want to provide?

URBANopt GHP project

What does this PR accomplish?

Change existing single GHE test to be closed-loop, which will overwrite the existing open-loop test

How should this be manually tested?

poetry run the test_single_ghe.py and then simulate the model in Dymola/OM

What are the relevant tickets?

None

Screenshots (if appropriate)

JingWang-CUB commented 10 months ago

This is a PR for the closed-loop changes but it's not ready for review yet. I will be actively working on this.

JingWang-CUB commented 9 months ago

CI is failing at modelica-formatter while it's passing on my computer. Any idea what's going on here? @vtnate Other than that, this PR is ready for your review.

vtnate commented 9 months ago

I'll check out the modelica-formatter issues, and will review as soon as this is green. Thanks!