The MVP currently available only supports a single GHE in the sys-param file. In reality multiple GHEs are common.
What does this PR accomplish?
Refactor system_parameters.get_param_by_building_id into .get_param_by_id
Additional work is required to loop through GHEs and build multi-GHE models appropriately. The strategy for that is being developed (modelica arrays or GMT-style individual models?).
How should this be manually tested?
CI should be sufficient. The important files are system_parameters.py & test_system_parameters.py.
Other changes:
Refactoring to use the renamed method
Ensuring there are unique ghe_ids in a single sys-param file and the same ghe_ids in different test files so they work together.
Any background context you want to provide?
The MVP currently available only supports a single GHE in the sys-param file. In reality multiple GHEs are common.
What does this PR accomplish?
Additional work is required to loop through GHEs and build multi-GHE models appropriately. The strategy for that is being developed (modelica arrays or GMT-style individual models?).
How should this be manually tested?
CI should be sufficient. The important files are system_parameters.py & test_system_parameters.py.
Other changes: