urbanopt / geojson-modelica-translator

GeoJSON to Modelica Translator that is focused on district energy system design and analysis.
https://www.nrel.gov/buildings/urbanopt.html
Other
18 stars 11 forks source link

Add district nominal pump head to system parameters file #610

Closed JingWang-CUB closed 7 months ago

JingWang-CUB commented 8 months ago

Any background context you want to provide?

MBLv10 has changes to their pump model which sets an upper bound to the actual pump head based on the nominal head. This has caused the 5G district models to fail if the nominal pump head is not set correctly.

What does this PR accomplish?

This PR fixes the above issue by allowing the users to change the nominal district pump head from the system parameters file.

How should this be manually tested?

poetry run pytest -m 'not dymola' tests/model_connectors/test_district_single_ghe.py

What are the relevant tickets?

609

Screenshots (if appropriate)