urbanopt / geojson-modelica-translator

GeoJSON to Modelica Translator that is focused on district energy system design and analysis.
https://www.nrel.gov/buildings/urbanopt.html
Other
18 stars 11 forks source link

Enable CLI to automatically build 5G systems that aren't GHE #621

Open vtnate opened 6 months ago

vtnate commented 6 months ago

Expected Behavior

We should seamlessly (from the user's perspective) create 5G systems that aren't GHE. We haven't yet supported waste heat via the CLI.

Actual Behavior

https://github.com/urbanopt/geojson-modelica-translator/blob/develop/geojson_modelica_translator/system_parameters/system_parameters.py#L734-L739 does not handle 5G buildings. We need either a new template, or a new building with a 5G ETS.

Steps to Reproduce

Generate a sys-param file using the CLI. Notice that the buildings are always 4G, even if the district is 5G.

Version Information

Modelica Buildings Library: 10.0.0 Modelica Standard Library: 4.0.0 TEASER: X.Y.Z Python: 3.12.2