search

urbanopt / geojson-modelica-translator

GeoJSON to Modelica Translator that is focused on district energy system design and analysis.
https://www.nrel.gov/buildings/urbanopt.html
Other
18 stars 11 forks source link

Templates and tests for horizontal piping modeling #627

Closed JingWang-CUB closed 2 months ago

JingWang-CUB commented 5 months ago

Any background context you want to provide?

UO GHP project

What does this PR accomplish?

Integrate new templates and tests for geothermal horizontal piping modeling.

  1. Added new template GroundCoupling.mot and accompanying python file.
  2. Included dependent network mo files (ConnectionSeriesAutosize.mo, UndisturbedSoilTemperature.mo, UnidirectionalSeries.mo).
  3. Included an external csv file to provide coefficients for calculating soil temperatures (Soil_temp_coefficients.csv).
  4. Added new coupling GroundCoupling_Borefield.
  5. Made modifications to tests test_district_single_ghe and test_uo_des to test the new horizontal piping features.

How should this be manually tested?

poetry run pytest tests/model_connectors/test_district_single_ghe.py

What are the relevant tickets?

Screenshots (if appropriate)

JingWang-CUB commented 2 months ago

Hi @vtnate , I'm having the following pre-commit error. Do you have any idea how to fix that? image

vtnate commented 2 months ago

Hi @vtnate , I'm having the following pre-commit error. Do you have any idea how to fix that?

Yes. I'll push a commit to your branch.

JingWang-CUB commented 2 months ago

@vtnate , looks like test_cli_runs_existing_5g_model is failing. I'm not sure why this is happening. I can take a look later. Could you please start your review meanwhile?

JingWang-CUB commented 2 months ago

@vtnate , I think all the pytests are passing now but we have some new errors under coveralls.