search

urbanopt / geojson-modelica-translator

GeoJSON to Modelica Translator that is focused on district energy system design and analysis.
https://www.nrel.gov/buildings/urbanopt.html
Other
18 stars 11 forks source link

Expose borehole variables #630

Closed nllong closed 4 months ago

nllong commented 5 months ago

Any background context you want to provide?

These variables were buried in the borFieDat within a borFie object.

What does this PR accomplish?

Expose the parameters to make them easier to set.

How should this be manually tested?

Tests alone should suffice.

What are the relevant tickets?

Screenshots (if appropriate)

nllong commented 4 months ago

I'm not really sure what's going on here, but I can see how this give modelica-builder access, and, as you say, the tests continue to pass.

This template (afaik) is only used in tests, not in real running of the GMT. Is this capability already covered in the main borefield templates? https://github.com/urbanopt/geojson-modelica-translator/blob/develop/geojson_modelica_translator/model_connectors/plants/templates/BorefieldOneUTube.mot and https://github.com/urbanopt/geojson-modelica-translator/blob/develop/geojson_modelica_translator/model_connectors/plants/templates/BorefieldTwoUTubes.mot?

I use this template for the 5G systems quite a bit. I would like to move over to a more configurable approach, but that hasn't happened yet, for me. Happy to jump on call.... which I think is needed.