urbanopt / geojson-modelica-translator

GeoJSON to Modelica Translator that is focused on district energy system design and analysis.
https://www.nrel.gov/buildings/urbanopt.html
Other
18 stars 11 forks source link

Upgrade OpenModelica #641

Open vtnate opened 2 months ago

vtnate commented 2 months ago

Any background context you want to provide?

A new version of OpenModelica was recently released. We can now take advantage of their "many improvements and bug fixes" in this newest version.

What does this PR accomplish?

nllong commented 2 months ago

tests failing? should I wait until that gets resolved to review?

vtnate commented 2 months ago

tests failing? should I wait until that gets resolved to review?

No, please review now. The tests are failing because in modelica_runner.py I'm referring to an image that doesn't exist yet.

Will you please:

  1. confirm that version 2.1.0 is correct
  2. build the image locally
  3. run the tests locally
  4. push the image to dockerhub

Once those are good, I can re-run CI and expect all green, then you can approve and we can merge it.