Open vtnate opened 2 months ago
tests failing? should I wait until that gets resolved to review?
tests failing? should I wait until that gets resolved to review?
No, please review now. The tests are failing because in modelica_runner.py I'm referring to an image that doesn't exist yet.
Will you please:
Once those are good, I can re-run CI and expect all green, then you can approve and we can merge it.
Any background context you want to provide?
A new version of OpenModelica was recently released. We can now take advantage of their "many improvements and bug fixes" in this newest version.
What does this PR accomplish?
cmake
to a different part of the Dockerfile to be as similar as possible to the OM Dockerfile ours is modeled onHow should this be manually tested?
2.1.0
(@nllong is that the right version for this change?)What are the relevant tickets?
Screenshots (if appropriate)