More tests - Githubissues

urbanopt / urbanopt-geojson-gem

OpenStudio Extension gem that translates a GeoJSON file into OpenStudio model inputs

Other

1 stars 3 forks source link

More tests #248

Closed vtnate closed 1 year ago

vtnate commented 1 year ago

Resolves #232

Pull Request Description

We found cases where our tests weren't accounting for new potential outcomes. This makes more tests to cover those cases

Checklist (Delete lines that don't apply)

[x] Unit tests have been added or updated
[ ] Documentation has been modified appropriately
[x] All ci tests pass (green)
[x] An issue has been created (which will be used for the changelog)
[x] This branch is up-to-date with develop

vtnate commented 1 year ago

@kflemin Jenkins passes all the tests but fails the rake task and still sets the build to green. I'm looking forward to relying on GHA instead of Jenkins.

vtnate commented 1 year ago

Refactoring to not require number_of_stories (as requested in #232) would take some thought. It, along with floor_to_floor_height, is used for the shading calculations in building.rb & helper.rb. Using maximum_roof_height and/or roof_elevation would not help because those aren't available with os-hpxml or osm either.