Fix: Update Ground Heat Exchanger Example files

urbanopt / urbanopt-geojson-gem

OpenStudio Extension gem that translates a GeoJSON file into OpenStudio model inputs

Other

1 stars 3 forks source link

Fix: Update Ground Heat Exchanger Example files #250

Closed tanushree04 closed 1 year ago

tanushree04 commented 1 year ago

Resolves #249

Pull Request Description

Uses single line segments for pipes in GHE network
Maintains correct order of connecting buildings and GHE in the district loop

Checklist (Delete lines that don't apply)

[x] All ci tests pass (green)
[x] An issue has been created (which will be used for the changelog)
[x] This branch is up-to-date with develop

tanushree04 commented 1 year ago

Most of the line diffs are just changing the indents, no? I found one typo as I scrolled through, otherwise this is great

The new GeoJSON files place the buildings and GHE so that they form a closed loop network and are in the right order. (Now the startFeatureID and DSID properties can be used to determine the order of the buildings). Angles in the pipe network are also avoided to avoid an extra junction between connectors.