Closed tanushree04 closed 4 days ago
looks good! just a few things to clarify
Thanks @kflemin! I just addressed the comments.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
lib/urbanopt/reopt/reopt_ghp_post_processor.rb | 75 | 84 | 89.29% | ||
lib/urbanopt/reopt/reopt_ghp_adapter.rb | 147 | 158 | 93.04% | ||
lib/urbanopt/reopt/reopt_ghp_api.rb | 72 | 89 | 80.9% | ||
<!-- | Total: | 297 | 334 | 88.92% | --> |
Totals | |
---|---|
Change from base Build 11753678791: | 4.3% |
Covered Lines: | 1003 |
Relevant Lines: | 1313 |
Resolves #154
Pull Request Description
This PR adds the following:
Adds methods to create input files for buildings and Ground Source Heat Pumps in a district to upload to the REopt API.
Adds methods to upload input files to the REopt API, run the financial metric analysis, and report output files back with the financial metrics to URBANopt.
These workflows can be tested using spec/tests/urbanopt_reopt_ghp_spec.rb
A reopt_ghp folder is created in the run directory of the URBANopt Scenario.
A reopt_ghp_inputs folder is created within ghte reopt_ghp folder, and contains the building and Ground Heat Exchanger input files created using these workflows. These files include information such as electricity consumption, URDB label, financial input defaults etc, as per the schema : lib/urbanopt/reopt/reopt_schema/reopt_output_schema.json
These input files are uploaded to the REopt API, which runs the financial analysis.
Post analysis, output files are created in a reopt_ghp_outputs folder within reopt_ghp. These output files contain financial metrics generated by the reopt analysis such as LCC, NPV, initial_capital_costs etc.. It also contains any errors or messages that were created during the analysis.
Checklist (Delete lines that don't apply)