search

urbanplatform / django-keycloak-auth

Middleware to allow authorization using Keycloak and Django for django-rest-framework (DRF). This package should only be used in projects starting from scratch, since it overrides the users' management.
MIT License
32 stars 14 forks source link

Fix _is_client_token_timed_out #14

Closed moritz89 closed 2 years ago

moritz89 commented 2 years ago

Why:

This change addresses the need by:

Closes #11

moritz89 commented 2 years ago

Hi, just wanted to ask if there are any blockers for this MR?

moritz89 commented 2 years ago

@simao-silva This would be a good first MR to get the ball rolling again. Could you review the changes and approve it if it looks good to you? This bug only affects users if they have set the env var DECODE_TOKEN to true. I've tested it on my stack, and since it is small bug fix should not have side-effects.

Subsequently, this would be a good reason of releasing a bug fix library update.

rjvitorino commented 2 years ago

I will try to review it today and let you know!

On Thu, 25 Aug 2022, 12:26 Moritz Ulmer, @.***> wrote:

@simao-silva https://github.com/simao-silva This would be a good first MR to get the ball rolling again. Could you review the changes and approve it if it looks good to you? This bug only affects users if they have set the env var DECODE_TOKEN to true. I've tested it on my stack, and since it is small bug fix should not have side-effects.

Subsequently, this would be a good reason of releasing a bug fix library update.

— Reply to this email directly, view it on GitHub https://github.com/urbanplatform/django-keycloak-auth/pull/14#issuecomment-1227132666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATFZGHTTA56K2NEGPZPEJLV25J7JANCNFSM5XYH7F5Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>