urbanriskmap / riskmap

Files for Cognicity RiskMap web, all deployments

GNU General Public License v3.0

5 stars 8 forks source link

Handle map & card error cases #57

Closed tomasholderness closed 7 years ago

tomasholderness commented 7 years ago

Map

~~Error 404 for random pages~~

Cards

~~Wrong/incorrect OTL link~~
~~Error on submission of completed card (i.e. at server end)~~

tomasholderness commented 7 years ago

Added console.log of errors when fetching or loading map layers
Use https://notifyjs.com/

tomasholderness commented 7 years ago

@ojha-url - not pretty but i added some examples of how to issue notifications in map.js and layers.js

tomasholderness commented 7 years ago

Currently, we're redirecting unknown routes to the map. This works locally, but not on prod.

Longer term we need to better understand how to catch errors listed in #65 in Aurelia routing and redirect to an error page.

matthewberryman commented 7 years ago

I could get cloudfront to redirect 404s to the map, however that would break the way I've got things set up for https://github.com/urbanriskmap/petabencana.id/issues/71

tomasholderness commented 7 years ago

Hi @matthewberryman - yes we had that locally, but I think the redirects are confusing. I propose we aim for 404 pages, with a link <a>"Return to Map"</a>. I'll try and sync with @mgvarley on this today.

ojha-url commented 7 years ago

@talltom, this got overwritten by some recent commit, i guess changes made to promise resolutions. Now there is no notification in case i enter an invalid report_id. Will look into it.