urbansim / urbansim_parcels

New version of urbansim_defaults for compatibility with new developer model
0 stars 1 forks source link

Python 3 compatibility #11

Closed pksohn closed 7 years ago

pksohn commented 7 years ago

(This is a very similar writeup to the PR in developer. Pay attention to the first bullet under the code changes section). This PR includes several code changes to be compatible with Python 3, and changes the Travis build to work with Python 3.5 and 3.6. This is necessarily in parallel with changes to developer, pandana, osmnet, and urbansim; running a simulation using Python 3 using this new codebase also requires Python 3 compatibility with several of the above. The Travis build currently grabs the py3-compatible branches of the above, so that will have to be updated over time.

Code compatibility changes

Travis build changes

Again, we'll just have to keep track of where the Travis builds are pulling code from. It should get much simpler as we merge changes into master branches.

pksohn commented 7 years ago

On that long bullet about the index names: it might just make sense to convert the H5 file via a one-time process and leave the code alone.

pksohn commented 7 years ago

Update: I reverted changes from this commit that converts bytes-type index names upon loading. Instead I upload an HDF5 file that has been converted - I think that's a more sustainable fix.