[v0.1.dev1] Merging ej-test with changes to compute_units_to_build()

alephcero commented 4 years ago

Related to issue #30

Replaces the to_frame() method for local.copy() for the parcels table
Establishes two different criteria for the creation of the feasibility DataFrame if there are several proposals to keep in the SqFtProForma.
Redesigns the compute_units_to_build() function, replacing the aggregate number of agents to allocate with a DataFrameWrapper with the agents information and the number of units with the name of the type of units for those agents. This function can now return an integer or a data frame for the units to build, as wells as taking the target vacancy as float or as an array.

smmaurer commented 4 years ago

The Travis builds are failing for reasons unrelated to this PR; i'll see if i can fix it.

smmaurer commented 4 years ago

Thanks @alephcero, and sorry for the slow reply!

About the breaking changes, i just meant to mention it in the change log. (And it's a good reason to make sure we're incrementing the dev version number.) It looks like this package hasn't even been declared a v0.1 yet, so i think the most important thing is just to make clear in the change log and PR writeups how the API is changing..

urbansim / urbansim_parcels

[v0.1.dev1] Merging ej-test with changes to compute_units_to_build() #32