urbansim / urbansim_parcels

New version of urbansim_defaults for compatibility with new developer model
0 stars 1 forks source link

Cleaning up installation and tests #33

Open smmaurer opened 4 years ago

smmaurer commented 4 years ago

This PR cleans up the Travis script and installation files. No substantive changes to the code.

Context is that this repo has not been in active development, and the Travis builds had stopped running because of a hiccup in the installation script.

Changes

I rewrote the Travis script to streamline installation (matching how a user would install the package), and in the process also cleaned up setup.py.

Testing

The core tests are passing, but the San Diego and San Francisco mini-models no longer run.

I haven't done any detailed diagnosis, but it looks like the API has changed for the developer model's custom_selection() function (log#L877), plus something about how data is passed for network aggregations (log#L617). I get the same errors on my Mac.

The last time these ran successfully in Travis was in June 2017: https://travis-ci.com/urbansim/urbansim_parcels/builds/49230838

Next steps

Taking a straw poll of @janowicz and others -- it's still helpful to keep those mini-models runnable, right?

So perhaps @alephcero can take a look at the errors and get them working. Feel free to push more changes to this PR branch.