Refactor developer - Githubissues

urbansim / urbansim_parcels

New version of urbansim_defaults for compatibility with new developer model

0 stars 1 forks source link

Closed pksohn closed 7 years ago

pksohn commented 7 years ago

Addresses #28. Reverses some of the changes from #25.

compute_units_to_build and merge methods moved out of the developer module into utils.py. Unit tests for these are moved to this repo as well.
Several variables removed from res_developer.yaml and nonres_developer.yaml config files; the only variables remaining are ones that should be read in as Developer object attributes.

pksohn commented 7 years ago

Added a couple commits to:

Simplify loading of proforma.yaml (pass to str_or_buffer parameter instead of yaml_str)
Get residential buildings to actually look feasible in the SF example. They were currently being passed NaNs for ave_sqft_per_unit, because there are no accessibility steps, and this caused the model to think there were no residential units in any potential building.

pksohn commented 7 years ago

Thanks for the review!