urbanspectra-nyc / nycsys

Pre-Owned Apple Systems, Bundles and Services.
MIT License
0 stars 1 forks source link

Use github pages for approvals #5

Closed jdonson closed 8 years ago

jdonson commented 8 years ago

This is a basic feature, as we need to do approvals thru github.....

We have two static pages targeted for this project:

  1. home-landing page
  2. systems-detail page

Learning to share a page thru github is KEY for approvals!

jdonson commented 8 years ago

https://pages.github.com/

Please create a page at github for approval with regard to #3

jdonson commented 8 years ago

You seemed to follow the instructions just right.... I went to the following url and saw "Hello world". http://nsoteriou.github.io/ Can you copy the home-landing.html page to that folder where you have text edits to get approved? (See #3 for those details.)

If so, then we can close this issue!! (y)

nsoteriou commented 8 years ago

nsoteriou.github.io/system-detail.html

jdonson commented 8 years ago

I was able to view that page, however... Corrections:

  1. this is not the correct page, and the url is also slightly off => please come from urbanspectra.com/sofiasys/
  2. styles/iphone.css is not where the css file exists. => please make sure that css file is properly referenced
  3. Please consider putting three directories beneath that nsoteriou.github.io personal approval pages folder:
  4. nycsys
  5. color
  6. events

Then I could approve the nycsys project pages under: nsoteriou.github.io/nycsys/{filename}

nsoteriou commented 8 years ago

-- first correction is clear, and I will come fro, that correct page -- I fixed the reference to css file - code pending. -- So you suggest three project subfolders underneath my approval folder? ?? we are only working on the first two projects first, ok?

jdonson commented 8 years ago

Thanks, yes, two projects (nycsys + webcolor) is PLENTY to start with.... Please notify me when you have those urls up for approval: http://nsoteriou.github.io/nycsys/ (index.html) http://nsoteriou.github.io/nycsys/system-detail.html

jdonson commented 8 years ago

I just saw two pages that look pretty good!

That means that you are now using github pages for approvals!

be sure to refer back to this issue if that requires some better review.