search

urbdyn / nexe_builds

Cache of nexe binary builds for easy use!
MIT License
12 stars 7 forks source link

Fix typo in `--no-mangle` argument. #43

Closed bruce-one closed 1 year ago

bruce-one commented 1 year ago

I saw an odd output when using these binaries:

$ ./nexe-builds-test
TEST NEXE SCRIPT
v18.14.0
os.userInfo() = {
...
}

Which seems like a bug, and from a quick look, I wondered if this typo might be why? Either way, the typo didn't seem intentional, so thought I'd create a PR :-)

code-ape commented 1 year ago

Thanks for this @bruce-one! To answer your question:

  1. The output you included in the PR description is intentional. It's the default script that the Nexe binary is built with. When you build the Nexe binary from scratch you have to supply some default index.js file for it to have. So we give it one that just prints a bit of info about the build and Node. The line that does it is below.

https://github.com/urbdyn/nexe_builds/blob/7289c5c261180222ea94bec4df393c10c2ddd8e2/bin/build_nexe#L111

  1. You are definitely correct that there is a typo! Thanks for the fix.