urbdyn / rules_fish

Bazel toolchain rules for Fish shell.
Apache License 2.0
2 stars 0 forks source link

Rewrite rlocation function in fish #6

Open Matthew-Benson opened 1 month ago

Matthew-Benson commented 1 month ago

Today, we package a standalone bash script for rlocation support for runfiles.

This also leaves us with a weird, hidden dependency on bash, which could cause issues stemming from system bash not being hermetic.

Unfortunately, the rlocation function we're getting from bash rules actually doesn't seem to work right in some cases with bzlmod. We should instead copy the logic from the Go library runfiles in our implementation.